-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non functional improvements #65
Conversation
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
304a74f
to
e3faee5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this @inteon, amazing work 🎉 💯!!
I added some more context to the comments, such that it is clear in the "contract" what is happening. These comments can guide in writing more unit tests to capture how things are working today. Then, in v2
, we might want to change some of the functionality, and then it is very clear what is changing when we can modify the same unit test output meanwhile.
63831ad
to
5f9c00c
Compare
ad85ea1
to
46e3f76
Compare
…, add copyright Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
5faa105
to
4f103b1
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
extracted all non-functional improvements from #61